Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(drain cleaner): considerations when using anti-affinity #9482

Merged
merged 2 commits into from
Dec 22, 2023
Merged

docs(drain cleaner): considerations when using anti-affinity #9482

merged 2 commits into from
Dec 22, 2023

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Dec 21, 2023 •
edited
Loading

Documentation

Updates the procedure for using the Drain Cleaner to include some general considerations when using anti-affinity on nodes.
Suggests using a spare worker node in case anti-affinity restrictions result in a pod being unschedulable and drain cleaner operation failing.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.40.0 milestone Dec 21, 2023
@PaulRMellor PaulRMellor self-assigned this Dec 21, 2023
fvaleri
fvaleri approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, but LGTM. Thanks.

documentation/modules/managing/proc-drain-cleaner-using.adoc Outdated Show resolved Hide resolved
documentation/modules/managing/proc-drain-cleaner-using.adoc Outdated Show resolved Hide resolved
documentation/modules/managing/proc-drain-cleaner-using.adoc Outdated Show resolved Hide resolved
@PaulRMellor PaulRMellor merged commit eb485e1 into strimzi:main Dec 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvaleri fvaleri fvaleri approved these changes

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

Assignees

@PaulRMellor PaulRMellor

Labels
None yet
Projects
None yet
Milestone
0.40.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulRMellor @scholzj @ppatierno @fvaleri